[Bugfix] Knowledge Base mx 2.0.2

[AmigaLink]

Diverse Fixe für die Knowledge Base mx 2.0.2

Code: Alles auswählen

#
#-----[ OPEN ]-----
#
includes/functions_kb.php

#
#-----[ FIND ]-----
#
      "'\[quote*?[^\[\]]*?\]'si",
      "'\[\/quote*?[^\[\]]*?\]'si",

#
#-----[ REPLACE WITH ]-----
#
//      "'\[toc*?[^\[\]]*?\]'si",
//      "'\[\/toc*?[^\[\]]*?\]'si",

#
#-----[ FIND ]-----
#
      "<div align=\"center\"><span class=\"gensmall\"><i>''",
      "''</i></span></div>",

#
#-----[ REPLACE WITH ]-----
#
//      "<div align=\"left\"><span class=\"genmed\"><u>",
//      "</u></span></div>",

#
#-----[ OPEN ]-----
#
includes/kb_article.php

#
#-----[ FIND ]-----
#
$article = make_clickable( $article );

#
#-----[ AFTER, ADD ]-----
#
$article = article_formatting( $article );

#
#-----[ FIND ]-----
#
         'PAGE_NUMBER' => sprintf( $lang['Page_of'], ( floor( $start / $kb_config['comments_pagination'] ) + 1 ), ceil( $num_of_replies / $kb_config['comments_pagination'] ) ),

#
#-----[ REPLACE WITH ]-----
#
         'PAGE_NUMBER' => ($num_of_replies > $kb_config['comments_pagination']) ? sprintf( $lang['Page_of'], ( floor( $start / $kb_config['comments_pagination'] ) + 1 ), ceil( $num_of_replies / $kb_config['comments_pagination'] ) ) : '',

#
#-----[ OPEN ]-----
#
includes/kb_cat.php

#
#-----[ FIND ]-----
#
   if ( $total_articles > 0 )

#
#-----[ REPLACE WITH ]-----
#
   if ( $total_articles > $kb_config['art_pagination'] )

#
#-----[ OPEN ]-----
#
includes/kb_header.php

#
#-----[ FIND ]-----
#
      'L_PORTAL' => "<<",

#
#-----[ REPLACE WITH ]-----
# // Choose yourself the right link and text you wants!!!
      'L_PORTAL' => '<a href="'.append_sid("portal.$phpEx").'" class="genmed">'.$lang['Portal'].'</a>',

#
#-----[ OPEN ]-----
#
templates/subSilver/kb_article_body.tpl

#
#-----[ FIND ]-----
#
      <td align="left" class="nav">
        <a href="{U_KB}" class="nav">{L_KB}</a> {PATH}
      </td>
      <td align="right" class="nav">
        <a href="{U_PRINT}" class="nav">{L_PRINT}</a>
      </td>

#
#-----[ REPLACE WITH ]-----
#
      <td align="left" class="nav">{L_PORTAL} <b>&raquo;</b> <a href="{U_KB}" class="nav">{L_KB}</a> {PATH}</td>
      <td align="right" class="nav"><a href="{U_PRINT}" class="nav">{L_PRINT}</a></td>

#
#-----[ FIND ]-----
#
      <span class="maintitle"style="font-size: 9pt;">{ARTICLE_TITLE}</span>

#
#-----[ REPLACE WITH ]-----
#
      <span class="maintitle"style="font-size: 22pt;"><b>{ARTICLE_TITLE}</b></span>

#
#-----[ OPEN ]-----
#
templates/subSilver/kb_cat_body.tpl

#
#-----[ FIND ]-----
#
      <td align="left" class="nav">
        <a href="{U_KB}" class="nav">{L_KB}</a> {PATH}
      </td>

#
#-----[ REPLACE WITH ]-----
#
      <td align="left" class="nav">{L_PORTAL} <b>&raquo;</b> <a href="{U_KB}" class="nav">{L_KB}</a> {PATH}</td>

#
#-----[ OPEN ]-----
#
templates/subSilver/kb_índex_body.tpl

#
#-----[ FIND ]-----
#
      <td align="left" class="nav"><a href="{U_KB}" class="nav">{L_KB}</a></td>

#
#-----[ REPLACE WITH ]-----
#
      <td align="left" class="nav">{L_PORTAL} <b>&raquo;</b> <a href="{U_KB}" class="nav">{L_KB}</a></td>

#
#-----[ OPEN ]-----
#
templates/subSilver/kb_rate_body.tpl

#
#-----[ FIND ]-----
#
      <input type="hidden" name="action" value="rate">
      <input type="hidden" name="id" value="{ID}">
      <input type="hidden" name="rate" value="dorate">
      </select>

#
#-----[ REPLACE WITH ]-----
#
      </select>
      <input type="hidden" name="action" value="rate">
      <input type="hidden" name="id" value="{ID}">
      <input type="hidden" name="rate" value="dorate">

#
#-----[ OPEN ]-----
#
templates/subSilver/kb_search_body.tpl

#
#-----[ FIND ]-----
#
      <td align="left"><span class="nav"><a href="{U_KB}" class="nav">{L_KB}</a></span></td>

#
#-----[ REPLACE WITH ]-----
#
      <td align="left"><span class="nav">{L_PORTAL} <b>&raquo;</b> <a href="{U_KB}" class="nav">{L_KB}</a></span></td>

#
#-----[ OPEN ]-----
#
templates/subSilver/kb_search_results.tpl

#
#-----[ FIND ]-----
#
   <td align="left"><span class="nav"><a href="{U_KB}" class="nav">{L_KB}</a></span></td>

#
#-----[ REPLACE WITH ]-----
#
   <td align="left"><span class="nav">{L_PORTAL} <b>&raquo;</b> <a href="{U_KB}" class="nav">{L_KB}</a></span></td>

#
#-----[ OPEN ]-----
#
templates/subSilver/kb_stats_body.tpl

#
#-----[ FIND ]-----
#
      <td align="left" class="nav">
        <a href="{U_KB}" class="nav">{L_KB}</a> {PATH}
      </td>

#
#-----[ REPLACE WITH ]-----
#
      <td align="left" class="nav">{L_PORTAL} <b>&raquo;</b> <a href="{U_KB}" class="nav">{L_KB}</a> {PATH}</td>

#
#-----[ OPEN ]-----
#
templates/subSilver/admin/kb_cat_admin_body.tpl

#
#-----[ FIND ]-----
#
<form action="{S_ACTION}" method="GET">

#
#-----[ REPLCE WITH ]-----
#
<form action="{S_ACTION}" method="post">

#
#-----[ OPEN ]-----
#
templates/subSilver/admin/kb_type_body.tpl

#
#-----[ FIND ]-----
#
<form action="{S_ACTION}" method="GET">

#
#-----[ REPLCE WITH ]-----
#
<form action="{S_ACTION}" method="post">


#
#-----[ SAVE/CLOSE ALL FILES ]-----
#
# EoM

Quelle

Zugefügt nach 12 Tag(en) 5 Stunde(n) 10 Minute(n):

Durch die Änderung in der includes/functions_kb.php wird die [toc] Funktion zerstört.
Ich habe deswegen den Codeblock angepasst und die schuldigen Zeilen auskommentiert. Wer möchte kann sie auch einfach löschen.

// EDIT
Wie ich eben feststellen musste sind diese fixes von oxpus. Ich hab die Quelle also mal schnell korrigiert!

[AmigaLink]

Und noch ein Fix von mir:

Code: Alles auswählen

#
#-----[ OPEN ]-----
#
includes/functions_kb.php

#
#-----[ FIND ]-----
#
      // insert the actual post text for our new post
      $sql = "INSERT INTO " . POSTS_TEXT_TABLE . " (post_id, post_subject, bbcode_uid, post_text) VALUES ($post_id, '$subject', '$bbcode_uid', '$message_update_text')";
      if ( !$db->sql_query( $sql, BEGIN_TRANSACTION ) )
      {
         $error_die_function( GENERAL_ERROR, 'Error in posting', '', __LINE__, __FILE__, $sql );
      }

#
#-----[ REPLACE WITH ]-----
#
      if ( $mode == 'newtopic' )
      {
         // insert the actual post text for our new post
         $sql = "INSERT INTO " . POSTS_TEXT_TABLE . " (post_id, post_subject, bbcode_uid, post_text) VALUES ($post_id, '$subject', '$bbcode_uid', '$message')";
         if ( !$db->sql_query( $sql, BEGIN_TRANSACTION ) )
         {
           $error_die_function( GENERAL_ERROR, 'Error in posting', '', __LINE__, __FILE__, $sql );
         }
      }
      else
      {
         $sql = "INSERT INTO " . POSTS_TEXT_TABLE . " (post_id, post_subject, bbcode_uid, post_text) VALUES ($post_id, '$subject', '$bbcode_uid', '$message_update_text')";
         if ( !$db->sql_query( $sql, BEGIN_TRANSACTION ) )
         {
           $error_die_function( GENERAL_ERROR, 'Error in posting', '', __LINE__, __FILE__, $sql );
         }
      }

#
#-----[ SAVE/CLOSE ALL FILES ]-----
#
# EoM

[AmigaLink]

Und noch einer (von modbo):

Code: Alles auswählen

#
# ----- [ OPEN ] -----
#
kb_footer.php

#
# ----- [ FIND ] -----
#
'L_QUICK_NAV' => $lang['Quick_nav'],

#
# ----- [ AFTER, ADD ] -----
#
'L_QUICK_CAT' => $lang['Quick_cat'],

#
# ----- [ OPEN ] -----
#
kb_footer.tpl

#
# ----- [ FIND ] -----
#
{L_QUICK_JUMP}

#
# ----- [ REPLACE, WITH ] -----
#
{L_QUICK_CAT}

#
# ----- [ OPEN ] -----
#
language/lang_german/lang_kb.php

#
# ----- [ FIND ] -----
#
$lang['Quick_nav'] = 'Quick KB Navigation';

#
# ----- [ AFTER, ADD ] -----
#
$lang['Quick_cat'] = 'Übersicht';

Quelle

[AmigaLink]

Und noch einer von oxpus:

Code: Alles auswählen

#
#----------[ OPEN ]-------------------------------------
#

includes/functions_kb.php

#
#----------[ FIND ]-------------------------------------
#

function kb_mailer(
   $to_id,
   $message,
   $subject,
   $from_id,
   $html_on = 0,
   $bbcode_on = 1,
   $smilies_on = 1)
{
   global $db, $lang, $user_ip, $board_config, $userdata, $phpbb_root_path, $phpEx;

   if ( !$from_id )
   {
      $from_id = $userdata['user_id'];
   }

   //get varibles ready
   $to_id = intval($to_id);
   $from_id = intval($from_id);
   $msg_time = time();
   $attach_sig = $userdata['user_attachsig'];
   
   //get to users info
   $sql = "SELECT user_id, user_notify_pm, user_email, user_lang, user_active
      FROM " . USERS_TABLE . "
      WHERE user_id = '$to_id'
         AND user_id <> " . ANONYMOUS;
   if ( !($result = $db->sql_query($sql)) )
   {
      $error = TRUE;
      $error_msg = $lang['No_such_user'];
   }

   $to_userdata = $db->sql_fetchrow($result);

   $privmsg_subject = trim(strip_tags($subject));
   if ( empty($privmsg_subject) )
   {
      $error = TRUE;
      $error_msg .= ( ( !empty($error_msg) ) ? '<br />' : '' ) . $lang['Empty_subject'];
   }

   if ( !empty($message) )
   {
      if ( !$error )
      {
         if ( $bbcode_on )
         {
            $bbcode_uid = make_bbcode_uid();
         }

         $privmsg_message = prepare_message($message, $html_on, $bbcode_on, $smilies_on, $bbcode_uid);
         $privmsg_message = str_replace('\\\n', '\n', $privmsg_message);

      }
   }
   else
   {
      $error = TRUE;
      $error_msg .= ( ( !empty($error_msg) ) ? '<br />' : '' ) . $lang['Empty_message'];
   }

   
   $script_name = preg_replace('/^\/?(.*?)\/?$/', "\\1", trim($board_config['script_path']));
    $script_name = ( $script_name != '' ) ? $script_name . '/privmsg.'.$phpEx : 'privmsg.'.$phpEx;
    $server_name = trim($board_config['server_name']);
    $server_protocol = ( $board_config['cookie_secure'] ) ? 'https://' : 'http://';
    $server_port = ( $board_config['server_port'] <> 80 ) ? ':' . trim($board_config['server_port']) . '/' : '/';

    include($phpbb_root_path . 'includes/emailer.'.$phpEx);
    $emailer = new emailer($board_config['smtp_delivery']);
               
    $emailer->from( $board_config['board_email'] );
    $emailer->replyto( $board_config['board_email'] );

    $emailer->email_address($to_userdata['user_email'] );
    $emailer->set_subject( $privmsg_subject );
   $emailer->msg = $privmsg_message;

    $emailer->send();
    $emailer->reset();
}
// get categories for index

#
#----------[ REPLACE WITH ]-----------------------------
#

function kb_mailer($to_id, $message, $subject, $from_id, $html_on = 0, $bbcode_on = 1, $smilies_on = 1)
{
   global $db, $lang, $user_ip, $board_config, $userdata, $phpbb_root_path, $phpEx;

   if ( !$from_id )
   {
      $from_id = $userdata['user_id'];
   }

   //get varibles ready
   $to_id = intval($to_id);
   $from_id = intval($from_id);
   $msg_time = time();
   $attach_sig = $userdata['user_attachsig'];

   //get to users info
   $sql = "SELECT user_id, username, user_notify_pm, user_email, user_lang, user_active
   FROM " . USERS_TABLE . "
      WHERE user_id = '$to_id'
         AND user_id <> " . ANONYMOUS;
   if ( !($result = $db->sql_query($sql)) )
   {
      $error = TRUE;
      $error_msg = $lang['No_such_user'];
   }

   $to_userdata = $db->sql_fetchrow($result);

   $privmsg_subject = trim(strip_tags($subject));
   if ( empty($privmsg_subject) )
   {
      $error = TRUE;
      $error_msg .= ( ( !empty($error_msg) ) ? '<br />' : '' ) . $lang['Empty_subject'];
   }

   if ( !empty($message) )
   {
      if ( !$error )
      {
         $message = strip_tags($message);
         $message = str_replace("[i]", '', $message);
         $message = str_replace("[/i]", '', $message);
         $message = str_replace("[b]", '', $message);
         $message = str_replace("[/b]", '', $message);
         $message = str_replace('[url=', '', $message);
         $message = str_replace('[/url]', ')', $message);
         $message = str_replace(']', ' (', $message);

         $message = unprepare_message($message);
       $message = preg_replace('/(/', '(', $message);
       $message = preg_replace('/)/', ')', $message);
       $message = preg_replace('/:/', ':', $message);
       $message = preg_replace('/[/', '[', $message);
       $message = preg_replace('/]/', ']', $message);
       $message = preg_replace('/{/', '{', $message);
       $message = preg_replace('/}/', '}', $message);
         $message = str_replace('\n', "\n", $message);
      }
   }
   else
   {
      $error = TRUE;
      $error_msg .= ( ( !empty($error_msg) ) ? '<br />' : '' ) . $lang['Empty_message'];
   }

   $script_name = preg_replace('/^\/?(.*?)\/?$/', "\\1", trim($board_config['script_path']));
   $script_name = ( $script_name != '' ) ? $script_name . '/kb.'.$phpEx : 'kb.'.$phpEx;
   $server_name = trim($board_config['server_name']);
   $server_protocol = ( $board_config['cookie_secure'] ) ? 'https://' : 'http://';
   $server_port = ( $board_config['server_port'] <> 80 ) ? ':' . trim($board_config['server_port']) . '/' : '/';

   include($phpbb_root_path . 'includes/emailer.'.$phpEx);
   $emailer = new emailer($board_config['smtp_delivery']);

   $emailer->from( $board_config['board_email'] );
   $emailer->replyto( $board_config['board_email'] );

   $emailer->email_address($to_userdata['user_email'] );
   $emailer->set_subject( $privmsg_subject );

   $emailer->use_template('kb_notify', $to_userdata['user_lang']);

   $emailer->assign_vars(array(
      'USERNAME' => $to_userdata['username'],
      'SITENAME' => $board_config['sitename'],
      'EMAIL_SIG' => (!empty($board_config['board_email_sig'])) ? str_replace('<br />', "\n", "-- \n" . $board_config['board_email_sig']) : '',
      'MESSAGE' => $message)
   );

   $emailer->send();
   $emailer->reset();
}
// get categories for index

#
#----------[ SAVE AND CLOSE ALL FILES ]-----------------
#
# EoM

Vorsicht, hier gibt es eine Fehlerhafte Darstellung im Codeblock. Deswegen ist der code auch nochmal in dem attachment enthalten!

[AmigaLink]

Und ich nochmal:

Code: Alles auswählen

#
#----------[ OPEN ]-------------------------------------
#

includes/functions_kb.php

#
#----------[ FIND ]-------------------------------------
#

   // if this is a new topic then insert the topic details
   if ( empty( $topic_id ) )
   {
      $mode = 'newtopic';
      $sql = "INSERT INTO " . TOPICS_TABLE . " (topic_title, topic_poster, topic_time, forum_id, topic_status, topic_type, topic_vote) VALUES ('$subject', " . $user_id . ", $current_time, $forum_id, " . TOPIC_UNLOCKED . ", $topic_type, $topic_vote)";
      if ( !$db->sql_query( $sql, BEGIN_TRANSACTION ) )
      {
         $error_die_function( GENERAL_ERROR, 'Error in posting', '', __LINE__, __FILE__, $sql );
      }
      $topic_id = $db->sql_nextid();
   }

#
#----------[ REPLACE WITH ]-----------------------------
#

   // if this is a new topic then insert the topic details
   if ( empty( $topic_id ) )
   {
      $mode = 'newtopic';
      $sql = "INSERT INTO " . TOPICS_TABLE . " (topic_title, topic_poster, topic_time, forum_id, topic_status, topic_type, topic_vote) VALUES ('$subject', " . $user_id . ", $current_time, $forum_id, " . TOPIC_UNLOCKED . ", $topic_type, $topic_vote)";
      if ( !$db->sql_query( $sql, BEGIN_TRANSACTION ) )
      {
         $error_die_function( GENERAL_ERROR, 'Error in posting', '', __LINE__, __FILE__, $sql );
      }
      $topic_id = $db->sql_nextid();
   }
   else
   {
      $sql = "SELECT topic_first_post_id 
            FROM " . TOPICS_TABLE . "
            WHERE topic_id = $topic_id";
      if ( !( $result = $db->sql_query( $sql ) ) )
      {
         $error_die_function( GENERAL_ERROR, "Could not obtain orig_post_id data", '', __LINE__, __FILE__, $sql );
      }
      $row = $db->sql_fetchrow( $result );
      $first_post_id = $row['topic_first_post_id'];

      $sql = "UPDATE " . POSTS_TABLE . " SET
                post_edit_time = $current_time, post_edit_count = post_edit_count + 1
         WHERE post_id = $first_post_id
         AND topic_id = $topic_id";
      if ( !$db->sql_query( $sql, END_TRANSACTION ) )
      {
         $error_die_function( GENERAL_ERROR, 'Error in posting', '', __LINE__, __FILE__, $sql );
      }
   }

#
#----------[ SAVE AND CLOSE ALL FILES ]-----------------
#
# EoM

Hiermit wird, jedesmal wenn ein KB-Artikel bearbeitet wird, der Editierungszähler vom erstem Beitrag des KB-Threads (im Forum) hochgesetzt.
Ist ganz interessant wenn das Bumping nicht aktiviert ist.

[AmigaLink]

Und noch ein Fix von oxpus:

Code: Alles auswählen

#
#----------[ OPEN ]-------------------------------------
#

includes/kb_post.php

#
#----------[ FIND ]-------------------------------------
#

         if ( $kb_is_auth['auth_mod'] || $kb_is_auth['auth_approval_edit'] ) // approval auth
         {
            $approve = 1;
            
            if ( $cat_switch )
            {
               update_kb_number( $old_category_id, ( $old_approve == 1 ? '- 1' : '0' ) );
               update_kb_number( $category_id, '+ 1' );
            }
            else
            {
               update_kb_number( $category_id, '+ 1' );
            }
         }
         else
         {
            $approve = 2;
            
            if ( $cat_switch )
            {
               update_kb_number( $old_category_id, ( $old_approve == 1 ? '- 1' : '0' ) );
            }
         }   

#
#----------[ REPLACE WITH ]-----------------------------
#

          if ( $kb_is_auth['auth_mod'] || $kb_is_auth['auth_approval_edit'] ) // approval auth
          {
            $approve = 1;
            
            if ( $cat_switch )
            {
               update_kb_number( $old_category_id, ( $old_approve == 1 ? '- 1' : '0' ) );
               update_kb_number( $category_id, '+ 1' );
            }
          }
          else
          {
            $approve = 2;
            
            if ( $cat_switch )
            {
               update_kb_number( $old_category_id, ( $old_approve == 1 ? '- 1' : '0' ) );
               update_kb_number( $category_id, '+ 1' );
            }
         }

#
#----------[ SAVE AND CLOSE ALL FILES ]-----------------
#
# EoM

[AmigaLink]

Und noch einer (von mir):

Code: Alles auswählen

#
#----------[ OPEN ]-------------------------------------
#

includes/function_kb.php

#
#----------[ FIND ]-------------------------------------
# in function get_kb_author();

      mx_message_die( GENERAL_ERROR, "Could not obtain author data", '', __LINE__, __FILE__, $sql );

#
#----------[ REPLACE WITH ]-----------------------------
#

      return ''; //mx_message_die( GENERAL_ERROR, "Could not obtain author data", '', __LINE__, __FILE__, $sql );

#
#----------[ FIND ]-------------------------------------
# in function get_kb_cat_list();

      mx_message_die( GENERAL_ERROR, "Could not obtain category information", '', __LINE__, __FILE__, $sql );

#
#----------[ REPLACE WITH ]-----------------------------
#

      return; //mx_message_die( GENERAL_ERROR, "Could not obtain category information", '', __LINE__, __FILE__, $sql );

#
#----------[ SAVE AND CLOSE ALL FILES ]-----------------
#
# EoM

[AmigaLink]

Und ein ganz wichtiger von dEfEndEr (der scheint momentan verschiedene MODs auf diese Schwachstelle zu prüfen ):

Code: Alles auswählen

#
#----------[ OPEN ]-------------------------------------
#

includes/kb_constats.php

#
#----------[ FIND ]-------------------------------------
#

// ---------------------------------------------------------------------START
// This file defines specific constants for the module
// -------------------------------------------------------------------------

#
#----------[ BEFORE, ADD ]------------------------------
#

if ( !defined('IN_PHPBB') )
{
   die("Hacking attempt");
}

#
#----------[ SAVE AND CLOSE ALL FILES ]-----------------
#
# EoM

[AmigaLink]

Noch ein kleiner Fix. Dieses mal von Billy Regal.

Code: Alles auswählen

#
#-----[ OPEN ]-----
#
templates/subSilver/kb_footer.tpl

#
#-----[ FIND ]-----
#
<input type="submit" value="{L_QUICK_CAT}" class="liteoption" /></span>

#
#-----[ REPLACE WITH ]-----
#
<input type="submit" value="{L_QUICK_JUMP}" class="liteoption" /></span>

#
#-----[ SAVE/CLOSE ALL FILES ]-----
#
# EoM